Skip to content

fix: add missing pinned/starred fields to in-memory feed adapter#784

Merged
hotlong merged 2 commits into
mainfrom
copilot/fix-ci-errors-build-test
Feb 22, 2026
Merged

fix: add missing pinned/starred fields to in-memory feed adapter#784
hotlong merged 2 commits into
mainfrom
copilot/fix-ci-errors-build-test

Conversation

Copilot AI commented Feb 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

FeedItemSchema added required pinned and starred boolean fields, but InMemoryFeedAdapter was not updated — causing TS2739 during DTS build in the Build Core CI job.

  • Added pinned: false and starred: false to FeedItem construction in in-memory-feed-adapter.ts
const item: FeedItem = {
  // ...existing fields
  pinned: false,
  starred: false,
  createdAt: now,
};
Original prompt

fix ci errors build and test

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@vercel

vercel Bot commented Feb 22, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectstack-play Ready Ready Preview, Comment Feb 22, 2026 4:05am
spec Ready Ready Preview, Comment Feb 22, 2026 4:05am

Request Review

@hotlong
fix: add missing pinned/starred fields to in-memory-feed-adapter
63e3a86 
The FeedItemSchema requires pinned and starred boolean fields, but the
in-memory-feed-adapter was not including them when constructing new
FeedItem objects, causing the DTS build to fail with TS2739.

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CI errors in build and test fix: add missing pinned/starred fields to in-memory feed adapter Feb 22, 2026
Copilot AI requested a review from hotlong February 22, 2026 04:01
@hotlong
hotlong marked this pull request as ready for review February 22, 2026 04:06
Copilot AI review requested due to automatic review settings February 22, 2026 04:06
@hotlong
hotlong merged commit 8c41379 into main Feb 22, 2026
5 checks passed
Copilot AI reviewed Feb 22, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a TypeScript compilation error in the CI build process caused by missing pinned and starred fields in the InMemoryFeedAdapter. The FeedItemSchema was updated to include these new boolean fields with default values, but the in-memory adapter's manual construction of FeedItem objects wasn't updated to match the TypeScript type requirements.

Changes:

  • Added pinned: false and starred: false to the FeedItem object construction in InMemoryFeedAdapter.createFeedItem() method

Comment thread packages/services/service-feed/src/in-memory-feed-adapter.ts
Comment on lines +150 to +151
pinned: false,
starred: false,

Copilot AI Feb 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test 'should create a feed item and return it' verifies other default fields (visibility, replyCount, isEdited) but doesn't verify the newly added pinned and starred fields. Consider adding assertions to check that item.pinned is false and item.starred is false to ensure these default values are properly set.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@hotlong hotlong Awaiting requested review from hotlong

Assignees

@hotlong hotlong

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hotlong